Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unnecessary css wrapping #12021

Merged
merged 1 commit into from
Oct 26, 2021
Merged

chore: Remove unnecessary css wrapping #12021

merged 1 commit into from
Oct 26, 2021
+2 −4

Conversation

mshabarov
Copy link
Contributor

@mshabarov mshabarov commented Oct 13, 2021 •
edited
Loading

Description

unsafeCSS function already wraps a value into CSS tagged literal, so the extra wrapping is not needed.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mshabarov mshabarov added +0.0.1 and removed +1.0.0 labels Oct 25, 2021
@pleku
Copy link
Contributor

pleku commented Oct 26, 2021

@mshabarov there is no issue reference to this ?

@mshabarov
Copy link
Contributor Author

@mshabarov there is no issue reference to this ?

@pleku no, this was noticed during fixing another issue.

@mshabarov mshabarov merged commit 4359497 into master Oct 26, 2021
@mshabarov mshabarov deleted the fix/remove-css-wrapping branch October 26, 2021 08:29
vaadin-bot pushed a commit that referenced this pull request Oct 26, 2021
@mshabarov @vaadin-bot
chore: Remove unnecessary CSS wrapping (#12021)
c1d7992
vaadin-bot pushed a commit that referenced this pull request Oct 26, 2021
@mshabarov @vaadin-bot
chore: Remove unnecessary CSS wrapping (#12021)
500ddde
vaadin-bot added a commit that referenced this pull request Oct 26, 2021
@vaadin-bot @mshabarov
chore: Remove unnecessary CSS wrapping (#12021) (#12160)
a549e84 
Co-authored-by: Mikhail Shabarov <[email protected]>
mshabarov added a commit that referenced this pull request Oct 27, 2021
@vaadin-bot @mshabarov
chore: Remove unnecessary CSS wrapping (#12021) (#12159)
6ca6139 
Co-authored-by: Mikhail Shabarov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleku pleku pleku approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.7 cherry-picked-8.0 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshabarov @pleku @vaadin-bot